-
Notifications
You must be signed in to change notification settings - Fork 20
solutions: reference designs: Added CN0584 page and sub-pages #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solutions: reference designs: Added CN0584 page and sub-pages #31
Conversation
|
Hi @gastmaier ,
|
416e78a to
7bdb27d
Compare
|
Just a nitpick for new screenshots/content, use png, jpg causes aberration around sharp edges. |
|
@jvelasc2 I'm traveling this week, but will review as soon as I can. Thanks for putting this together! |
docs/solutions/reference-designs/eval-cn0584-ebz/HDL-project/index.rst
Outdated
Show resolved
Hide resolved
| - :dokuwiki:`AXI_AD3552R IP core </resources/fpga/docs/axi_ad3552r>` | ||
| - :dokuwiki:`AXI_LTC2387 IP core </resources/fpga/docs/axi_ltc2387>` | ||
| - :dokuwiki:`AD3552R Dual Channel, 16-Bit, 33 MUPS, Multispan, Multi-IO SPI DAC Linux device driver <resources/tools-software/linux-drivers/iio-dac/axi-ad3552r>` | ||
| - :dokuwiki:`LTC2387 SAR ADC IIO Linux Driver <resources/tools-software/linux-drivers/iio-adc/ltc2387>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvelasc2 these should point to docs in https://analogdevicesinc.github.io/hdl/library/index.html
@gastmaier should we point directly to the URL for the core documentation, or is there a role? (Just thinking ahead if stuff moves around)
|
|
||
| The DAC data may be sourced from an internal data generator (DDS or pattern), | ||
| from the external DDR via DMA or from the ADC. The source control selection can | ||
| be made by updating the :dokuwiki:`REG_CHAN_CNTRL_7 (DAC Channel) </resources/fpga/docs/hdl/regmap#:~:text=DAC%20Channel%20(axi_ad*)>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvelasc2 I THINK this would be the new URL: https://analogdevicesinc.github.io/hdl/user_guide/ip_cores/axi_dac/index.html#dac-channel
@gastmaier does this make sense?
|
@jvelasc2 , @gastmaier , a couple of other observations and questions: There are a few zip files that may want to move somewhere else - python files that may be more appropriate in pyadi-iio, boot files that might be incorporated into Kuiper Linux or some other CI build process. Most of the images look okay, but are probably not up to standard. Can we leave as-is for now, and work with the apps engineers to re-shoot as svg (or whatever makes the most sense)? Lastly, the HDL project page is pretty redundant to https://analogdevicesinc.github.io/hdl/projects/cn0585/index.html. I'd say let's leave as-is for the moment, and work with the apps engineers on updating. |
|
Hi Mark @thorenscientific , -- Joyce |
37ba96a to
28b17e8
Compare
Signed-off-by: Joyce Velasco <joyce.velasco@analog.com>
28b17e8 to
bba183a
Compare
|
Hi @jvelasc2 , the hdl project page is always at hdl repo: You can use the search to quick find pages across repos, like this search under hdl they also named it as cn0585 instead of cn0584 but it seems to be the same project since the cn0584 is listed as supported boards and the search finds it. for now you don't have to do changes, since I am reviewing, just a heads up |
Fix references, ensure they are unique, use shell, whitespace, remove duplicated hdl page Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Make matlab-configuration ref unique. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
References to other repos must use external references (the title is obtained from the ref) this is not Because a similar page under
I agree, but for public they need to be under analog's sw-download.
Yes... totally agree... i hate ugly screenshots.
Yup, removed. If I deleted content not over cn05867, please, re-add, but under the hdl repo... |
|
|
Hi @gastmaier , |
…devicesinc#31) Signed-off-by: Joyce Velasco <joyce.velasco@analog.com> Reviewed-by: Jorge Marques <jorge.marques@analog.com>
Type
Checklist
make htmloradoc serve: