drivers: pwm: pwm-axi-pwmgen: Add support for 16 channels #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
alin724
force-pushed
the
update_pwm_gen_16ch
branch
from
a9be4a1 to
e84fbb4
Compare
Add support for up to 16 PWM output channels and update to the corresponding [period,width,offset] regs' addresses Signed-off-by: Alin-Tudor Sferle <Alin-Tudor.Sferle@analog.com>
alin724
force-pushed
the
update_pwm_gen_16ch
branch
from
e84fbb4 to
0f81415
Compare
nunojsa
approved these changes
Nov 13, 2023
|
|
||
| pwm->chip.npwm = axi_pwmgen_read(pwm, AXI_PWMGEN_REG_NPWM); | ||
| if (pwm->chip.npwm > 4) | ||
| if (pwm->chip.npwm > 16) |
Collaborator
There was a problem hiding this comment.
small nit: Maybe add a define for the number of channels since you're doing this change...
amiclaus
approved these changes
Nov 13, 2023
Contributor
amiclaus
left a comment
amiclaus
left a comment
There was a problem hiding this comment.
ltgm, after rest of the comments are addressed.
Collaborator
|
Well, 6h went so I will merge this... If you want to make the change to have a #define, we can always have a follow up PR |
Contributor
Author
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will add support for up to 16 PWM output channels and update to the corresponding [period,width,offset] regs' addresses.
HDL repo PR;