Skip to content

drivers: pwm: pwm-axi-pwmgen: Add support for 16 channels #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023
Merged

drivers: pwm: pwm-axi-pwmgen: Add support for 16 channels #2336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions drivers/pwm/pwm-axi-pwmgen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
#define AXI_PWMGEN_REG_CONFIG 0x10
#define AXI_PWMGEN_REG_NPWM 0x14
#define AXI_PWMGEN_CH_PERIOD_BASE 0x40
#define AXI_PWMGEN_CH_DUTY_BASE 0x44
#define AXI_PWMGEN_CH_PHASE_BASE 0x48
#define AXI_PWMGEN_CHX_PERIOD(ch) (AXI_PWMGEN_CH_PERIOD_BASE + (12 * (ch)))
#define AXI_PWMGEN_CHX_DUTY(ch) (AXI_PWMGEN_CH_DUTY_BASE + (12 * (ch)))
#define AXI_PWMGEN_CHX_PHASE(ch) (AXI_PWMGEN_CH_PHASE_BASE + (12 * (ch)))
#define AXI_PWMGEN_CH_DUTY_BASE 0x80
#define AXI_PWMGEN_CH_PHASE_BASE 0xC0
#define AXI_PWMGEN_CHX_PERIOD(ch) (AXI_PWMGEN_CH_PERIOD_BASE + (4 * (ch)))
#define AXI_PWMGEN_CHX_DUTY(ch) (AXI_PWMGEN_CH_DUTY_BASE + (4 * (ch)))
#define AXI_PWMGEN_CHX_PHASE(ch) (AXI_PWMGEN_CH_PHASE_BASE + (4 * (ch)))
#define AXI_PWMGEN_TEST_DATA 0x5A0F0081
#define AXI_PWMGEN_LOAD_CONIG BIT(1)
#define AXI_PWMGEN_RESET BIT(0)
Expand Down Expand Up @@ -196,7 +196,7 @@ static int axi_pwmgen_setup(struct pwm_chip *chip)
}

pwm->chip.npwm = axi_pwmgen_read(pwm, AXI_PWMGEN_REG_NPWM);
if (pwm->chip.npwm > 4)
if (pwm->chip.npwm > 16)
Copy link
Collaborator

@nunojsa nunojsa Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: Maybe add a define for the number of channels since you're doing this change...

return -EINVAL;

/* Disable all the outputs */
Expand Down