misc: mathworks: fix some -Wint-to-pointer-cast #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some 32bits architectures (like those in RPIs) support LPAE (Large Physical Address Extension) which means phys_addr_t will be of 'u64' type. Therefore we can have some int-to-pointer-cast warnings if not properly casting (in calls like virt_to_page()). Hence, first cast to uintptr_t before doing (void *). Signed-off-by: Nuno Sá <nuno.sa@analog.com>
nunojsa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich and
rbolboac
as code owners
gastmaier
approved these changes
Aug 5, 2025
Contributor
gastmaier
left a comment
gastmaier
left a comment
There was a problem hiding this comment.
This warning is funny :)
if (inode == NULL)
{
MW_DBG_text("INODE is NULL\n"); // hum something is not right...
}
// ... proceeds to immediately de-reference it
mw_ip_info = container_of(inode->i_cdev, struct mathworks_ip_info, cdev);
mhennerich
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Some 32bits architectures (like those in RPIs) support LPAE (Large Physical Address Extension) which means phys_addr_t will be of 'u64' type. Therefore we can have some int-to-pointer-cast warnings if not properly casting (in calls like virt_to_page()). Hence, first cast to uintptr_t before doing (void *).
PR Type
PR Checklist