Skip to content

arm:dts:overlays: Add overlay for ADALM-LSMSPG board#3175

Merged
nunojsa merged 1 commit intoanalogdevicesinc:rpi-6.12.yfrom
thorenscientific:rpi_staging/add_lsmspg_overlay
Mar 30, 2026
Merged

arm:dts:overlays: Add overlay for ADALM-LSMSPG board#3175
nunojsa merged 1 commit intoanalogdevicesinc:rpi-6.12.yfrom
thorenscientific:rpi_staging/add_lsmspg_overlay

Conversation

@thorenscientific
Copy link
Copy Markdown

@thorenscientific thorenscientific commented Mar 7, 2026

PR Description

Adding device tree overlay for the ADALM-LSMSPG board that will release within a month.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@thorenscientific thorenscientific force-pushed the rpi_staging/add_lsmspg_overlay branch 2 times, most recently from ec33375 to ea482b1 Compare March 7, 2026 16:13
amiclaus
amiclaus reviewed Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments on my side.

arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts Outdated
/ {
compatible = "brcm,bcm2835", "brcm,bcm2837", "brcm,bcm2711", "brcm,bcm2712";

fragment@0 {
Copy link
Copy Markdown
Contributor

@amiclaus amiclaus Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the fragment syntax is no longer preferred.

arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts
fragment@2 {
target = <&i2c1>;
__overlay__ {
#size-cells = <0>;
Copy link
Copy Markdown
Contributor

@amiclaus amiclaus Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing indentation

arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts Outdated
status = "okay";
clock-frequency = <400000>;
lm75: lm75@48 {
compatible = "lm75";
Copy link
Copy Markdown
Contributor

@amiclaus amiclaus Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the compatible correct here? (national,)

@thorenscientific thorenscientific force-pushed the rpi_staging/add_lsmspg_overlay branch 2 times, most recently from 9cb87e7 to 59d865c Compare March 13, 2026 16:45
@thorenscientific
Copy link
Copy Markdown
Author

thorenscientific commented Mar 13, 2026

Thanks @amiclaus ! Applied all of your suggestions, and tested the compiled overlay on my setup here.

nunojsa
nunojsa reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment from me. From a process standpoint, commit subject should be improved: ARM: dts: overlays: Add overlay for ADALM-LSMSPG board and we should also have a brief message stating what this board/DT is about.

arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts
label = "my_lsmspg_ad5593r";
#gpio-cells = <2>;
gpio-controller;

Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci complains look valid. You're missing #address-cells = <1>; and size-cells = <0>;

Copy link
Copy Markdown
Author

@thorenscientific thorenscientific Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nunojsa , I un-commented the minimum address-cells, size cells that cleared the ci complaints - it looks like lots of overlays have this (commented cells parameters), I need to dig in and understand what they do (for the future).
Also fixed the commit subject and description.

Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are basically needed if you have child nodes. To better understand:

https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#address-cells-and-size-cells

@thorenscientific thorenscientific force-pushed the rpi_staging/add_lsmspg_overlay branch 2 times, most recently from 610b14e to 3b10c6b Compare March 25, 2026 14:57
nunojsa
nunojsa reviewed Mar 26, 2026
View reviewed changes
arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts
adi,mode = <CH_MODE_GPIO>;
adi,off-state = <CH_OFFSTATE_PULLDOWN>; // input
};

Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we still have the warning... I believe we need the properties both under ad5593r@10 and ad5593r@0

@thorenscientific thorenscientific force-pushed the rpi_staging/add_lsmspg_overlay branch 4 times, most recently from db70512 to d206b5a Compare March 27, 2026 15:59
nunojsa
nunojsa reviewed Mar 27, 2026
View reviewed changes
arch/arm/boot/dts/overlays/rpi-adalm-lsmspg-overlay.dts Outdated
};

&{/} {
one-bit-adc-dac@0 {
Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think what CI complains in here is that you don't need @0. Just one-bit-adc-dac. The @0 implies reg = <0>; or that a ranges property exists.

@thorenscientific
ARM: dts: overlays: Add overlay for ADALM-LSMSPG board
d0cdd97 
This is a training board for device driver concepts, based on
AD5592r (SPI), AD5593r (I2C) ADC/DAC/GPIO and LM75 temperature sensor.

Signed-off-by: Mark Thoren <mark.thoren@analog.com>
@thorenscientific thorenscientific force-pushed the rpi_staging/add_lsmspg_overlay branch from d206b5a to d0cdd97 Compare March 27, 2026 17:57
@thorenscientific
Copy link
Copy Markdown
Author

thorenscientific commented Mar 28, 2026

Thanks @nunojsa for the advice and patience. @amiclaus can you give this a last look and merge? This should make it into the next Kuiper RC :)

@nunojsa nunojsa merged commit fc4873c into analogdevicesinc:rpi-6.12.y Mar 30, 2026
23 checks passed
@nunojsa
Copy link
Copy Markdown
Collaborator

nunojsa commented Mar 30, 2026

Thanks @nunojsa for the advice and patience. @amiclaus can you give this a last look and merge? This should make it into the next Kuiper RC :)

Then a backport to https://github.com/analogdevicesinc/linux/tree/rpi/release/linux-6.12.y-2026r1 is needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amiclaus amiclaus amiclaus approved these changes

@nunojsa nunojsa nunojsa approved these changes

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thorenscientific @nunojsa @amiclaus