clk: adi: fix invalid IS_ERR() checks of of_iomap() in SC5xx clock drivers#3236
Merged
qasim-ijaz merged 4 commits intoadsp-6.12.0-yfrom Apr 13, 2026
Merged
clk: adi: fix invalid IS_ERR() checks of of_iomap() in SC5xx clock drivers#3236qasim-ijaz merged 4 commits intoadsp-6.12.0-yfrom
qasim-ijaz merged 4 commits intoadsp-6.12.0-yfrom
Conversation
of_iomap() returns NULL on failure, not an error pointer. Replace the IS_ERR() checks with NULL checks in sc57x_clock_probe(). Fixes: df2ba6d ("clk: adi: Add clock driver for ADSP-SC573") Signed-off-by: Qasim Ijaz <qasim.ijaz@analog.com>
of_iomap() returns NULL on failure, not an error pointer. Replace the IS_ERR() checks with NULL checks in sc58x_clock_probe(). Fixes: b288b42 ("clk: adi: Add clock driver for ADSP-SC589") Signed-off-by: Qasim Ijaz <qasim.ijaz@analog.com>
of_iomap() returns NULL on failure, not an error pointer. Replace the IS_ERR() checks with NULL checks in sc594_clock_probe(). Fixes: 9cf6b0c ("clk: adi: Add clock driver for ADSP-SC594") Signed-off-by: Qasim Ijaz <qasim.ijaz@analog.com>
of_iomap() returns NULL on failure, not an error pointer. Replace the IS_ERR() checks with NULL checks in sc598_clock_probe(). Fixes: 71b82fe ("clock: Add driver for ADSP-SC5xx") Signed-off-by: Qasim Ijaz <qasim.ijaz@analog.com>
artursartamonovsadi
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of_iomap() returns NULL on failure, but the ADI SC5xx clock drivers
check its return value with IS_ERR(). As a result, failed mappings are
not detected correctly. Fix this by replacing the IS_ERR() checks with
NULL checks.
PR Type
PR Checklist