feat(macos): app document icon for markdown files - #33
Merged
Conversation
Add src-tauri/Info.plist so the generated CFBundleDocumentTypes gain CFBundleTypeIconSystemGenerated, which tells macOS 11+ to draw a document icon from the app icon. A .md/.markdown/.mdx then shows the DocsReader mark in Finder for anyone who sets DocsReader as their default app for the type. The entries restate what bundle.fileAssociations already generates, since the CLI merges a user Info.plist by replacing keys wholesale; keep the two in sync. Build-time metadata only - no runtime code, no effect on performance or UX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
src-tauri/Info.plistso macOS draws a DocsReader document icon for .md/.markdown/.mdx (via CFBundleTypeIconSystemGenerated on macOS 11+), for users who set DocsReader as their default handler. The entries restate what fileAssociations generates (the CLI replaces user Info.plist keys wholesale, source-verified) plus the icon key. Build-time metadata only: no runtime code, no performance or UX impact; worst case is no icon, never breakage. Ships in 0.11.1.