Skip to content

Validate developer log URL requests#680

Merged
wagoodman merged 1 commit intomainfrom
validate-dev-log-url
Mar 10, 2026
Merged

Validate developer log URL requests#680
wagoodman merged 1 commit intomainfrom
validate-dev-log-url

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

@wagoodman wagoodman commented Mar 10, 2026

The DeveloperLogURL returned by Apple's notarization API was being fetched without any validation, which could allow a malicious or compromised API response to redirect requests to internal services or arbitrary external hosts. This PR fixes this by adding URL validation before fetching notarization logs.

Specific security protections that were added:

  • a new domain allowlist (apple.com or from the specific logs s3 bucket)
  • a new denylist for any non-host (IP) values
  • warn on any unexpected host values (things not on the allow list)
  • HTTPS enforcement (HTTP and other schemes not allowed)
  • the same rules are applied when there are redirects as well

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman added the security related to a security fix label Mar 10, 2026
@wagoodman wagoodman requested a review from a team March 10, 2026 14:03
@wagoodman wagoodman self-assigned this Mar 10, 2026
@wagoodman wagoodman added this to OSS Mar 10, 2026
@wagoodman wagoodman moved this to In Review in OSS Mar 10, 2026
@wagoodman wagoodman merged commit e41d66a into main Mar 10, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in OSS Mar 10, 2026
@wagoodman wagoodman deleted the validate-dev-log-url branch March 10, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security related to a security fix

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants