Do not allow for unbounded reads for user controlled input#681
Merged
Do not allow for unbounded reads for user controlled input#681
Conversation
spiffcs
approved these changes
Mar 10, 2026
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses potential memory exhaustion from unbounded
io.ReadAllcalls when reading HTTP responses and files. Previously, if a server returned an unexpectedly large response, quill would attempt to read the whole payload into memory.There were a few different vectors for this, all have been addressed by adding limits based on realistic inputs (with wide margins):
Stacked PRs