Fix missing nested packages in package-lock.json v1 - #5108
Merged
Conversation
Signed-off-by: Eljees <57435526+Eljees@users.noreply.github.com>
Signed-off-by: Eljees <57435526+Eljees@users.noreply.github.com>
wagoodman
approved these changes
Jul 27, 2026
Contributor
Author
|
I'm glad could have helped!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catalog nested dependency entries in npm package-lock v1 files. Previously, Syft only visited the top-level dependency map, so conflicting versions installed below another package were missing from the SBOM.
This change:
Type of change
Testing
go test ./syft/pkg/cataloger/javascript -count=1go vet ./syft/pkg/cataloger/javascriptChecklist
Issue references
Fixes #5101