Skip to content

[codex] Fix Symfony extension deprecation - #13

Merged
cristoforocervino merged 1 commit into
andanteproject:mainfrom
tacman:fix-deprecation
May 4, 2026
Merged

[codex] Fix Symfony extension deprecation#13
cristoforocervino merged 1 commit into
andanteproject:mainfrom
tacman:fix-deprecation

Conversation

@tacman

@tacman tacman commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the HttpKernel Extension base-class import with the DependencyInjection Extension import.
  • Keeps the bundle extension API unchanged while avoiding the Symfony 8.1 internal/deprecated class warning.

Root cause

Symfony 8.1 considers Symfony\Component\HttpKernel\DependencyInjection\Extension internal/deprecated for bundle extensions. The public base class now lives at Symfony\Component\DependencyInjection\Extension\Extension.

Validation

  • php -l src/DependencyInjection/AndanteTimestampableExtension.php
  • vendor/bin/phpunit tests/Functional/DependencyInjection/DefaultConfigTest.php
  • vendor/bin/phpstan analyse src/DependencyInjection/AndanteTimestampableExtension.php currently stops on existing phpstan.neon options: checkMissingIterableValueType and checkGenericClassInNonGenericObjectType

References #12

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cristoforocervino
cristoforocervino self-requested a review April 29, 2026 07:49
@cristoforocervino cristoforocervino self-assigned this Apr 29, 2026
@cristoforocervino

Copy link
Copy Markdown
Member

Thanks @tacman !

@cristoforocervino

Copy link
Copy Markdown
Member

@tacman the PR is still in draft. Is it done?

@tacman
tacman marked this pull request as ready for review April 29, 2026 08:43
@tacman

tacman commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@tacman the PR is still in draft. Is it done?

Yep, I think it's all set!

@cristoforocervino
cristoforocervino merged commit 170d90f into andanteproject:main May 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants