Fix: fetch sra metadata retraction module#32
Merged
gp201 merged 4 commits intoandersen-lab:mainfrom Sep 12, 2025
Merged
Conversation
…present when is_retracted is True
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug where SRA samples that are not retracted were incorrectly being assigned retraction dates, and includes minor maintenance improvements for code clarity and consistency.
- Fixed SRA retraction module bug and added assertions for retraction consistency validation
- Changed process execution method from
shelltoscriptfor better compatibility - Updated pipeline version and improved code formatting
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workflows/flusra.nf | Renamed unused lambda parameter and improved formatting of filter operations |
| nextflow.config | Incremented pipeline version from 1.5.1 to 1.5.2 |
| modules/nf-core/sratools/prefetch/main.nf | Changed process execution from shell to script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where an SRA sample that is not retracted was being assigned a retraction date.
It also includes minor updates to improve code clarity and maintain consistency across the pipeline. The main changes are a switch from
shelltoscriptfor process execution, variable renaming for clarity, and minor formatting improvements. The version number has also been incremented.Fix
General improvements and maintenance:
shelltoscriptin theSRATOOLS_PREFETCHprocess for better compatibility and maintainability (modules/nf-core/sratools/prefetch/main.nf).1.5.1to1.5.2innextflow.config.Code clarity and formatting:
srato_srain theFLUSRAworkflow to indicate it is not used (workflows/flusra.nf).