Skip to content

Fix: fetch sra metadata retraction module#32

Merged
gp201 merged 4 commits intoandersen-lab:mainfrom
gp201:fix/fetch_sra_metadata_retraction_module
Sep 12, 2025
Merged

Fix: fetch sra metadata retraction module#32
gp201 merged 4 commits intoandersen-lab:mainfrom
gp201:fix/fetch_sra_metadata_retraction_module

Conversation

@gp201
Copy link
Copy Markdown
Collaborator

@gp201 gp201 commented Sep 12, 2025

This pull request fixes a bug where an SRA sample that is not retracted was being assigned a retraction date.
It also includes minor updates to improve code clarity and maintain consistency across the pipeline. The main changes are a switch from shell to script for process execution, variable renaming for clarity, and minor formatting improvements. The version number has also been incremented.

Fix

  • Add assertions enforcing SRA retraction consistency (retracted => has date; not retracted => no date)

General improvements and maintenance:

  • Changed process execution from shell to script in the SRATOOLS_PREFETCH process for better compatibility and maintainability (modules/nf-core/sratools/prefetch/main.nf).
  • Updated pipeline version from 1.5.1 to 1.5.2 in nextflow.config.

Code clarity and formatting:

  • Renamed the unused lambda parameter from sra to _sra in the FLUSRA workflow to indicate it is not used (workflows/flusra.nf).

@gp201 gp201 enabled auto-merge (squash) September 12, 2025 20:53
@gp201 gp201 requested a review from Copilot September 12, 2025 20:53
@gp201 gp201 disabled auto-merge September 12, 2025 20:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a bug where SRA samples that are not retracted were incorrectly being assigned retraction dates, and includes minor maintenance improvements for code clarity and consistency.

  • Fixed SRA retraction module bug and added assertions for retraction consistency validation
  • Changed process execution method from shell to script for better compatibility
  • Updated pipeline version and improved code formatting

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
workflows/flusra.nf Renamed unused lambda parameter and improved formatting of filter operations
nextflow.config Incremented pipeline version from 1.5.1 to 1.5.2
modules/nf-core/sratools/prefetch/main.nf Changed process execution from shell to script

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gp201 gp201 enabled auto-merge (squash) September 12, 2025 20:53
@gp201 gp201 disabled auto-merge September 12, 2025 20:57
@gp201 gp201 merged commit cae48d8 into andersen-lab:main Sep 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants