Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Updated Spanish translations from en file#71

Merged
andi34 merged 2 commits intoandi34:devfrom
natastro:photobooth-es
Jun 29, 2020
Merged

Updated Spanish translations from en file#71
andi34 merged 2 commits intoandi34:devfrom
natastro:photobooth-es

Conversation

@natastro
Copy link
Copy Markdown

Translated en.json using a mix of what was on es.json and translating the new lines. In reference to #64

Please let me know if I need to change anything or if you need anything else :) Thank you!!

Copy link
Copy Markdown
Owner

@andi34 andi34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think some small parts should be changed. Not sure if I am right, see comments. I've started learning Spanish years ago but stopped with it once I was out of school... long time ago 🙈

Comment thread resources/lang/es.json Outdated
Comment thread resources/lang/es.json Outdated
@natastro
Copy link
Copy Markdown
Author

Hi @andi34 ! Looks like the new commit went through. Please let me know if anything else is needed and thank you for your input!

@andi34 andi34 merged commit 1efd2f8 into andi34:dev Jun 29, 2020
@andi34
Copy link
Copy Markdown
Owner

andi34 commented Jun 29, 2020

Thanks @stroudn1!
After #70 there's 2 more to translate. You'd like to look at those 2 too?

@natastro
Copy link
Copy Markdown
Author

@andi34 Absolutely! Can I begin translating now or should I wait?

@andi34
Copy link
Copy Markdown
Owner

andi34 commented Jun 30, 2020

Great! You could commit your changes to the feature/qr-ssid and create a PR for same branch, this would allow me to merge it to the main branch in one "topic".

@natastro
Copy link
Copy Markdown
Author

natastro commented Jul 1, 2020

Thank you @andi34 :) I was looking at en.json - is this where the 2 new ones are? Sorry for the confusion

@andi34
Copy link
Copy Markdown
Owner

andi34 commented Jul 1, 2020

Yeah it is.

qrHelp was adjusted,

"qrHelp": "To download the picture to your smartphone, connect to the WiFi:",

2 new:

"general_wifi_ssid": "Wireless network name (SSID) used to access the photobooth",
 "manual_general_wifi_ssid": "Please define the wireless network name (SSID) to be used to access the Photobooth. The wireless network name (SSID) is displayed on the results page when the QR code is called up.",

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants