Skip to content

Unify naming schema #283

@T-002

Description

@T-002

Hi andialbrecht,

I am using sqlparse for a data analysis project. It works (nearly) as expected. From my point of view, there is one naming issue that could be adjusted:

type(is_keyword) ==  bool
type(is_group) == method
type(is_whitespace) == method

I found it rather confusing having the same naming schema for different invocation. In my opinion there are two valid adjustments you could make:

  • is_keyword could become a method, or
  • you could add the @Property decorator to is_group and is_whitespace

From my opinion the second option is preferable.
What do you think about it?

Best regards,

Christian

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions