-
Notifications
You must be signed in to change notification settings - Fork 717
Closed
Description
Hi andialbrecht,
I am using sqlparse for a data analysis project. It works (nearly) as expected. From my point of view, there is one naming issue that could be adjusted:
type(is_keyword) == bool
type(is_group) == method
type(is_whitespace) == methodI found it rather confusing having the same naming schema for different invocation. In my opinion there are two valid adjustments you could make:
- is_keyword could become a method, or
- you could add the @Property decorator to is_group and is_whitespace
From my opinion the second option is preferable.
What do you think about it?
Best regards,
Christian
Metadata
Metadata
Assignees
Labels
No labels