Skip to content

Conversation

@vmuriart
Copy link
Contributor

Refactor of grouping.py to simplify/clarify the different sections.

note, small behavior change on invalid identifiers introduced. Otherwise behavior should be the same

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage decreased (-0.7%) to 88.299% when pulling 1e770d9 on vmuriart:refactor into 9ab1464 on andialbrecht:master.

@vmuriart
Copy link
Contributor Author

I'm porting back various refactored sections from my fork. I'll submit various small pr instead of a massive one with all the changes.

coverage decrease most likely due to some of the utilities already backported but not being used yet.

@andialbrecht andialbrecht merged commit efb6fd4 into andialbrecht:master May 15, 2016
@andialbrecht
Copy link
Owner

Wow! Thanks a lot! The code looks more modern and since all tests pass I think it's fine to merge it. I just skimmed through the changes as the changeset is pretty large. But it looks good so far!

@vmuriart
Copy link
Contributor Author

@andialbrecht I'm being really careful on which sections of code after being ported at which point from my fork to avoid introducing any breaking behaviors.

The lexer was the next one I was thinking about porting back. Wasn't sure if there was any particular reason you went with using a meta class instead of regular functions or a regular class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants