-
Notifications
You must be signed in to change notification settings - Fork 717
Refactor #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #235
Conversation
remove slots in subclasses
leaving sql.Operations in for future PR small behavior changed for invalid identifier
|
I'm porting back various refactored sections from my fork. I'll submit various small coverage decrease most likely due to some of the utilities already backported but not being used yet. |
|
Wow! Thanks a lot! The code looks more modern and since all tests pass I think it's fine to merge it. I just skimmed through the changes as the changeset is pretty large. But it looks good so far! |
|
@andialbrecht I'm being really careful on which sections of code after being ported at which point from my fork to avoid introducing any breaking behaviors. The |
Refactor of grouping.py to simplify/clarify the different sections.
note, small behavior change on
invalid identifiersintroduced. Otherwise behavior should be the same