Skip to content

Conversation

@swarnat
Copy link
Contributor

@swarnat swarnat commented Oct 22, 2025

Thanks for contributing!

Before submitting your pull request please have a look at the
following checklist:

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
  • your changes are documented, if needed

"INTERSECT" must be a closing keyword for WhereConverter. Otherwise SQL Queries, which use that combination, cannot be parsed.
Docs: https://learn.microsoft.com/en-us/sql/t-sql/language-elements/set-operators-except-and-intersect-transact-sql?view=sql-server-ver17

@andialbrecht andialbrecht requested a review from Copilot November 25, 2025 17:39
@andialbrecht andialbrecht added this to the 0.5.4 milestone Nov 25, 2025
Copilot finished reviewing on behalf of andialbrecht November 25, 2025 17:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds 'INTERSECT' as a closing keyword for the WHERE clause in the SQL parser, ensuring that SQL queries using WHERE clauses followed by INTERSECT operations can be properly parsed.

  • Added 'INTERSECT' to the M_CLOSE tuple of the Where class to handle INTERSECT set operations
  • Aligns INTERSECT behavior with other set operators (UNION, UNION ALL, EXCEPT) that already close WHERE clauses
  • Enables proper parsing of SQL queries containing WHERE...INTERSECT patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andialbrecht andialbrecht merged commit e37ea5b into andialbrecht:master Nov 25, 2025
6 checks passed
@andialbrecht
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants