fix(build): musl legs drop llvm-inprocess for a pure-static link (#7353) - #9
Merged
Merged
Conversation
…ryTS#7353) The musl release/manual-build legs could not statically link the glibc-built in-process LLVM: versioned refs (__isoc23_*@@GLIBC_2.38) and -lz3/-lxml2/-lffi system libs neither link into musl, and a forced link yields a musl+glibc hybrid that segfaults at startup. - perry: perry-codegen no longer uses workspace = true (cargo ignores default-features = false on inherited deps); llvm-inprocess is now opt-in via default instead of perry-codegen's default feature - workflows: musl legs build --no-default-features --features full-cli and a new Verify step asserts the binary is fully static (no INTERP) - .cargo/config.toml: per-target rustflags prepend the musl libc.a dir (build-script -L dirs won glibc's libc.a) and disable fortify for musl C compiles (__memcpy_chk missing in musl on aarch64) Musl binaries now shell out to LLVM tools (opt/llc) at compile time, like pre-PerryTS#7353 builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The musl release/manual-build legs could not statically link the glibc-built in-process LLVM: versioned refs (_isoc23*@@GLIBC_2.38) and -lz3/-lxml2/-lffi system libs neither link into musl, and a forced link yields a musl+glibc hybrid that segfaults at startup.
Musl binaries now shell out to LLVM tools (opt/llc) at compile time, like pre-PerryTS#7353 builds.
Summary
Changes
Related issue
Test plan
cargo build --releasecleancargo test --workspace --exclude perry-ui-ios --exclude perry-ui-tvos --exclude perry-ui-watchos --exclude perry-ui-gtk4 --exclude perry-ui-android --exclude perry-ui-windowspassestest-files/or a#[test]in the affected cratedocs/src/-p perry-ui-<backend>locally on that platformScreenshots / output
Checklist
feat:/fix:/docs:/chore:prefix convention used in the log