fix(themes): widen the picker's trigger and move it to the end of ASCII's header - #282
Merged
Conversation
The trigger is 44px tall for the touch target, so `rounded-pill` clamps to a 22px radius. With 4px of horizontal padding a short name like `ice` came out about as wide as it was tall — a circle with a few pixels of straight edge. `px-md` gives the label room on either side. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It is the least program-specific control up there — it changes what the program is drawn in, not what the conversion does — so it reads and tabs last, after `about` and the AI key control. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andraderaul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small header changes, both from looking at the Theme picker and not liking what was there.
The trigger read as a circle, not a pill
ThemeControlis 44px tall for the touch target, sorounded-pillclamps to a 22px radius. Withpx-xs(4px on the deck's scale) a short name likeicecame out roughly as wide as it was tall —a circle with a few pixels of straight edge in the middle, rather than a pill.
px-mdgives the label room on either side. The pill stays.The picker moves to the end of ASCII//Convert's header
It is the least program-specific control up there — it changes what the program is drawn in, not
what the conversion does — so it now reads and tabs last, after
aboutand the AI key control.One consequence worth naming: the header group is right-anchored with
ml-auto, so growing thefirst item only stretched the group's left edge and left its neighbours alone. Now that the picker
is last, switching
ice→constructshiftsaboutandconfigure aileft by the widthdifference. Small, and only on an explicit click, but real — a follow-up is planned.
Checks
check,test:runandcommitlintall ran green in the pre-commit hook — the full suite acrossevery workspace. Neither change was looked at in a browser; the pixel figures above are computed
from the tokens (
--text-xs: 11px,--tracking-wide: 0.08em), not measured.🤖 Generated with Claude Code