Unnessecary Sidebar updates??

[IIHERO4]

Hello, i noticed in our server there was alot of cpu-time going to sending scoreboard (in Bedwars1058) so which at time i thought it was normal.

I looked into the source and i saw that the plugin sends alot of unnessecary packets, i fixed it by checking prefix and suffix before and after setting content which is already a huge improvement as for my case the only thing changing from packet to packet is Sidebar.suffix and Sidebar.prefix.

Although this change worked nicely for my case, It needs a look from you as developers that uses your library may implement their own ScoreLine which will cause unexpected behavior if we are just checking for prefix and suffix.

My Patch:

    public void refreshPlaceholders() {
        for (ScoreLine str : this.lines) {
            if (str.text.isHasPlaceholders()) {
                // Some code here in parsing content
                
                String oldSuffix = str.suffix;
                String oldPrefix = str.prefix;
                str.setContent(content);

                // ignore Intellij Idea warning if present
                if (!oldSuffix.equals(str.suffix) || !oldPrefix.equals(str.prefix)) { 
                    str.sendUpdate();
                }
            }
        }
    }

This is old version of bw1058, But its equivilant to https://github.com/andrei1058/SiderbarLib/blob/6731c0aca53cf0390b14a08f9e55966bdf1faee1/sidebar-base/src/main/java/com/andrei1058/spigot/sidebar/WrappedSidebar.java#L138-L145

[IIHERO4]

Just FYI, When running the plugin with this code and only 1 player is online*

                .....

                if (!oldSuffix.equals(str.suffix) || !oldPrefix.equals(str.prefix)) {
                    System.out.println("UPDATING");
                    str.sendUpdate();
                } else {
                    System.out.println("NOT UPDATING");
                }

[20:21:14 INFO]: [Server Thread] CraftPlayer{name=KYSHERO}D are printed between runs of the task

In my case, we are saving 7 packets per player, This is the scoreboard that is being rendered. (Basically only the a packet is sent for the gen time), This also Saved alot of packets when a player is in the main lobby as almost no changes is done while in lobby

[andrei1058]

I will consider that! Thanks for your time.

[andrei1058]

implemented with #15