chore: switch to shared r2-cache action from shared-ai-standards#25
chore: switch to shared r2-cache action from shared-ai-standards#25andreiships-bot merged 2 commits intodevfrom
Conversation
Replace local .github/actions/r2-cache with the shared composite action from andreiships/shared-ai-standards. The shared action is functionally identical but parameterized (cache-api configurable) and bundled with its own curl-retry.sh. Changes: - setup-bun: update r2-cache refs to cross-repo SHA-pinned reference - setup-bun: wire metrics-script for Axiom telemetry - Delete .github/actions/r2-cache/ (replaced by shared action) - Delete scripts/lib/curl-retry.sh (bundled in shared action)
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
andreiships-bot
left a comment
There was a problem hiding this comment.
Single-pass Review — Claude
Verdict: LGTM (one nitpick on PR title)
The migration is well-executed. SHA is pinned to current main of shared-ai-standards (41b2466c), which is exactly the commit that introduced the metrics-script input — the two changes are correctly coordinated. No dangling references to the deleted files were found.
Findings
[Nitpick] PR title uses ci: prefix — not in the allowed list per CONTRIBUTING.md
CONTRIBUTING.md lists: feat:, fix:, docs:, chore:, refactor:, test:. The prefix ci: is absent (the bot correctly flagged this). Suggested fix: chore: switch to shared r2-cache action from shared-ai-standards
Verification checklist
| Check | Result |
|---|---|
SHA 41b2466c exists in shared-ai-standards |
✓ Valid — is current main HEAD |
SHA commit introduces metrics-script input |
✓ feat(r2-cache): add metrics-script input for cross-repo telemetry |
scripts/ci/r2-cache-metrics.sh still present on PR branch |
✓ Not deleted |
scripts/lib/curl-retry.sh fully removed |
✓ Gone from file tree |
Local .github/actions/r2-cache/ fully removed |
✓ Gone from file tree |
| Other workflow/action files referencing old paths | ✓ None found |
Shared action cache-api default |
✓ https://cache.pistachiorama.ai — correct |
metrics-script path guard in shared action |
✓ Blocks ../ traversal, warns on missing file |
Logic change is zero — the shared action bundles curl-retry.sh internally (sourced as ${ACTION_PATH}/curl-retry.sh), so removing the local copy is safe.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Closes #26
Summary
.github/actions/r2-cachewith the shared composite action fromandreiships/shared-ai-standardssetup-buncomposite action to reference cross-repo SHA-pinned actionmetrics-scriptinput for Axiom telemetry (usingscripts/ci/r2-cache-metrics.sh).github/actions/r2-cache/(replaced by shared action)scripts/lib/curl-retry.sh(bundled inside the shared action)chore:PRs in pr-standards (maintenance tasks don't need issues)Changes
.github/actions/setup-bun/action.yml: switch 2 r2-cache usages toandreiships/shared-ai-standards/.github/actions/r2-cache@41b2466c+ addmetrics-script.github/actions/r2-cache/action.yml: deleted (220 lines)scripts/lib/curl-retry.sh: deleted (62 lines, bundled in shared action).github/workflows/pr-standards.yml: skip linked-issue check forchore:PRsRelated
Part of the shared CI actions rollout:
andreiships/shared-ai-standardshosts the canonical action at.github/actions/r2-cache.