fix(product-api): surface pending-review worktree artifacts on Products page - #534
Merged
carlospedreira merged 4 commits intoJun 26, 2026
Conversation
IBondarenko-iwg
marked this pull request as ready for review
June 23, 2026 17:08
carlospedreira
added
type:bug
ChatGPT Codex Connector
carlospedreira
approved these changes
Jun 26, 2026
carlospedreira
left a comment
carlospedreira
left a comment
Collaborator
There was a problem hiding this comment.
Looks good after the pending-worktree raw fallback test update.
mirzazekicapi
pushed a commit
to mirzazekicapi/dotbot
that referenced
this pull request
Jun 26, 2026
PR andresharpe#534 (fix andresharpe#519) landed Issue E upstream. Their Get-PendingReviewProductRoot filters to needs-review status only (vs our all-active-worktrees approach), uses HashSet dedup, and extracts New-RawProductResponse helper. Took upstream version entirely. Issue E now fully covered by upstream. Remaining unique changes: B (interview-answers.json), D (output delta). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #519
Summary of changes
Get-ProductList,Get-ProductDocument, andGet-ProductDocumentRawonly read from the mainworkspace/product/. When a task parks atneeds-review, its artifacts live in the task's git worktree — invisible to the reviewer.Added
Get-PendingReviewProductRoothelper that scans task files forneeds-reviewstatus (both schema-v2workflow-runs/layout and legacy flat layout), cross-referencesworktree-map.json, and returns the product dirs of matching worktrees. All three API functions now fall back to these pending roots. Main location takes precedence — no duplicates. In-progress task artifacts are excluded.Screenshots / recordings
Testing notes
needs-reviewin its task JSONpending_reviewflagAutomated: new test cases added to
tests/Test-Components.ps1covering pending artifact listing, dedup (main wins),Get-ProductDocumentfallback, in-progress exclusion, and missing worktree-map graceful handling.Checklist