ACL Design, Implementation, Testing

• ACL Design Document

  • https://github.com/Azure/SONiC/wiki/ACL-High-Level-Design

• ACL Implementation (Components, DB, Data Flow, etc)

  • sonic-swss: Orchestration Agent (https://github.com/Azure/sonic-swss/tree/master/orchagent)
    • orchdaemon.cpp (https://github.com/Azure/sonic-swss/blob/master/orchagent/orchdaemon.cpp#L80)
    • aclorch.cpp (https://github.com/Azure/sonic-swss/blob/master/orchagent/aclorch.cpp)
  • sonic-sairedis (https://github.com/Azure/sonic-sairedis)
    • (https://github.com/Azure/sonic-sairedis/blob/master/meta/sai_meta_acl.cpp)

• Database (Redis DB)

  • Schema (https://github.com/Azure/sonic-swss/blob/master/doc/swss-schema.md)
  • APP_DB (#0) + ASIC_DB (#1)
    docker exec -it database redis-cli

• Testing (https://github.com/Azure/sonic-mgmt)

  • Testbed tests
    • Code (https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/tasks/acltb.yml)
    • How to use (https://github.com/Azure/sonic-mgmt/blob/master/ansible/README.test.md)
  • Development (sanity) tests
    • Code (https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/tasks/acl.yml)
    • How to use
      Setup: One DUT + one host + one connection

      +---------------+        +---------------+  
      |      Ethernet0|<------>|eth0           |  
      |               |        |               |  
      |   DUT         |        |     Host      |  
      +---------------+        +---------------+    

      ansible-playbook -i inventory --limit {DUT_NAME} test_sonic.yml -b --tags acl -e "ptf_host={PTF_HOST} ptf_host_if=eth1 switch_if=Ethernet0"

• Development Process

  • Design: create new/update existing document (https://github.com/Azure/SONiC/wiki/Design-Guidelines)
  • Design review (community meeting?)
  • Coding/Testing/Debugging (see Testing chapter)
  • Contributing
    • GitHub way: fork/change/push/pull-request/(receive comments-fix)/merged
    • Same with the tests (if needed)