Remove brushdesigner dependency - #89
Merged
Merged
Conversation
maxmmitchell
force-pushed
the
migrate-brushdesigner-to-brushgraph
branch
from
August 6, 2026 13:41
af78e70 to
4f9a68d
Compare
maxmmitchell
force-pushed
the
migrate-brushdesigner-to-brushgraph
branch
from
August 6, 2026 13:43
4f9a68d to
bf3cbb4
Compare
maxmmitchell
changed the title
maxmmitchell
changed the title
maxmmitchell
marked this pull request as ready for review
August 6, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a code cleanup, we can get delete most of the
brushdesignercode, as thebrushgraphUI is the primary medium for custom brush editing now.First, we need to change the dependency direction, as some of
brushgraphdepends on parts ofbrushdesigner. Sincebrushdesigneris going to be deleted, we can move most of these files intobrushgraph, since most were only used by the brush editors. With the exception of a few files which make more sense incore/data(CustomBrushDaoandCustomBrushEntity).The only remaining file outside of
brushdesignerwhich depends onbrushdesignerisCahierNavGraph, but we'll save that removal for the following step, where we will delete the entry points tobrushdesigner, and update the UI. Finally, we'll delete thebrushdesignercode itself.