Fix installer Linux audio dependencies - #6
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1daa59133
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
|
|
||
| missing_packages="" | ||
| for package_name in libasound2 libasound2-plugins; do |
There was a problem hiding this comment.
Install libasound2t64 on Ubuntu 24.04
On a minimal Ubuntu 24.04 (Noble) installation—the WSLg scenario this change targets—libasound2 is a virtual package rather than an installable package. I checked apt-get install --simulate --yes libasound2 on Noble, which reports that it is provided by libasound2t64 and then fails with Package 'libasound2' has no installation candidate. Consequently, when ALSA is absent, the new dependency step exits under set -e before Termleaf is downloaded; detect/install libasound2t64 on systems where that is the concrete package, or otherwise resolve the available provider.
Useful? React with 👍 / 👎.
What changed
libasound2andlibasound2-pluginsthroughapt-getwhen needed.Why
Termleaf uses Rodio/CPAL's ALSA backend on Linux. WSLg exposes its Windows audio
route through PulseAudio, but a minimal Ubuntu installation may not include the
ALSA PulseAudio plugin. In that case Termleaf cannot open a default output stream
and runs silently.
The installer now supplies the missing runtime dependency instead of leaving the
application installed without working audio.
Validation
sh -n termleaf-installer.shgit diff --checkcargo test --locked(84 passed, 1 hardware test ignored)cargo test --locked audio::tests::hardware_audio_callback_stays_alive -- --ignored --nocaptureassets/typewriter-return.wavwithaplay