Expose internal API marked as internal#114
Closed
dgolovin wants to merge 1 commit intoangelozerr:masterfrom
dgolovin:internal-packages-available
Closed
Expose internal API marked as internal#114dgolovin wants to merge 1 commit intoangelozerr:masterfrom dgolovin:internal-packages-available
dgolovin wants to merge 1 commit intoangelozerr:masterfrom
dgolovin:internal-packages-available
Conversation
Owner
There was a problem hiding this comment.
Why do you add TernModulesPropertyPage inside tern.eclipse.ide.jsdt? This page is already added inside tern.eclipse.ide.ui ?
Contributor
Author
There was a problem hiding this comment.
Oh, that is my mistake. PR was all about adding internal packages and mark them as x-internal:=true
Owner
|
I don't like very welll using x-internal I find it breaks OSGi concept. But I'm very opened to change TernModulesPropertyPage in a non internal package. What do you think about that? |
Expose internal API and mark it as x-internal so any use of such API is maked with warning in eclipse PDE
Contributor
Author
|
I'd love that, thanks. I did some tests and have PR #115 ready for you. |
Owner
Contributor
Author
|
This PR was rejected and replaced with #115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose internal API and mark it as x-internal so any use of such API is maked
with warning in eclipse PDE. This is approach eclipse uses as well, so devs
still can use internal API on theyr own risk.
In our case we'd like to expose Tern/Modules project properties under different
category.