Skip to content

Guard optional UEFI dispatch registration#703

Merged
ltfish merged 3 commits into
masterfrom
wasm-host-followup
Jul 24, 2026
Merged

Guard optional UEFI dispatch registration#703
ltfish merged 3 commits into
masterfrom
wasm-host-followup

Conversation

@zardus

@zardus zardus commented Jul 22, 2026

Copy link
Copy Markdown
Member

Follow-up to #702.

The merged cleanup registers singledispatch handlers whose annotations refer to uefi_firmware even when that optional dependency is unavailable. On Pyodide, importing CLE then fails while resolving those annotations.

This keeps the dependency-specific handlers and backend registration conditional, adds a subprocess regression test for importing without uefi_firmware, and selects the tandem PyVEX branch through tool.uv.sources.

@angr-bot

Copy link
Copy Markdown
Member

Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/cle_703

Comment thread pyproject.toml Outdated
Comment thread cle/backends/uefi_firmware.py Outdated
Comment thread cle/backends/uefi_firmware.py Outdated
@twizmwazin

Copy link
Copy Markdown
Member

Can you also open a PR adding pyoxide CI akin to the pyvex one?

@zardus zardus mentioned this pull request Jul 22, 2026
@zardus

zardus commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Opened #704 with Pyodide CI analogous to PyVEX. It builds the PyVEX WebAssembly wheel, installs CLE into a Pyodide virtualenv, and runs the CLE tests there.

@zardus
zardus requested a review from twizmwazin July 22, 2026 02:06
@ltfish
ltfish merged commit dff2e1e into master Jul 24, 2026
39 of 44 checks passed
@ltfish
ltfish deleted the wasm-host-followup branch July 24, 2026 00:43
@ltfish

ltfish commented Jul 24, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants