Guard optional UEFI dispatch registration#703
Merged
Conversation
Member
Author
This was referenced Jul 22, 2026
Member
|
Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/cle_703 |
twizmwazin
reviewed
Jul 22, 2026
twizmwazin
reviewed
Jul 22, 2026
twizmwazin
reviewed
Jul 22, 2026
Member
|
Can you also open a PR adding pyoxide CI akin to the pyvex one? |
Member
Author
|
Opened #704 with Pyodide CI analogous to PyVEX. It builds the PyVEX WebAssembly wheel, installs CLE into a Pyodide virtualenv, and runs the CLE tests there. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #702.
The merged cleanup registers singledispatch handlers whose annotations refer to uefi_firmware even when that optional dependency is unavailable. On Pyodide, importing CLE then fails while resolving those annotations.
This keeps the dependency-specific handlers and backend registration conditional, adds a subprocess regression test for importing without uefi_firmware, and selects the tandem PyVEX branch through tool.uv.sources.