Slottify Relocation and its subclasses. - #707
Merged
Merged
Conversation
Every Relocation instance carried a per-instance __dict__. Declare __slots__ on the base class and on all 181 subclasses across all backends (ELF, PE, Mach-O, COFF, TLS, externs, binja); subclasses that add attributes (ELFReloc, IMAGE_REL_BASED_HIGHADJ, R_ARM_THM_CALL, MachO relocations, InternalTLSRelocation, SimDataSimpleRelocation) declare exactly those, everything else declares empty slots. On a 46 MB PE with ~235k base relocations (OUTLOOK.EXE), a relocation object shrinks from 176 to 104 bytes (48 + 128-byte dict -> dict-free), cutting the relocation object layer from 39.6 MB to 23.4 MB. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
It always mirrored owner.arch, so storing it per instance wasted a slot (and a reference) on every relocation. A PE base relocation drops from 104 to 96 bytes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/cle_707 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Relocation class is reduced from ~170 bytes to ~96 bytes. On a PE file (
OUTLOOK.exe) with 230k relocations, we save about 18 MB of RAM.