Update upstream#198
Merged
GulajavaMinistudio merged 14 commits intoangular-indonesia:masterfrom Jun 8, 2018
Merged
Conversation
Before this fix, the beta would not satisfy the updated range. Since Angular released a beta today it uncovered this issue.
It should be more resilient to those changes in the future.
…irst declared The comparator function for project names was invalid; sort() expect to be consistent and in this case was returning 1 for a set of arguments, and 0 if arguments were reversed, leading inconsistencies in the sort result.
While Filipe and Hans are on vacation, code owners become more of a burden than a solution.
…resolver - If you look at https://github.com/webpack-contrib/less-loader#less-resolver, it states that if you provide paths, it will use the less resolver. We should only use the less-resolver when stylePreprocessorOptions.includePaths are actually given. - This fixes issues where if in your less file you `@import "~@dependency/less-file";` it actually resolves correct and when you import something like `@import "some-local-file";` it actually recompiles when `ng build --watch` is ran.
…ndency class This should allow multiple webpack versions in the workspace dependencies with no weird errors. Fix #6417 for good.
…to ngtools/webpack Should go in only together with "feat(@ngtools/webpack): allow passing in the right ContextElementDependency class".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.