Skip to content

Conversation

@SethDavenport
Copy link
Member

@SethDavenport SethDavenport commented Jan 2, 2017

Now that Angular 4 is in beta, we need to update our package's naming since ng2-redux doesn't make a lot of sense any more.

After conferring with my colleagues we're thinking of also taking the opportunity to move to scoped pages under our github org (@angular-redux).

The current idea is as follows:

  • ng2-redux -> @angular-redux/store [UPDATED, was core before]
  • ng2-redux-router -> @angular-redux/router
  • ng2-redux-form -> @angular-redux/form

... with potentially others down the line.

This PR starts the process of updating ng2-redux to @angular-redux/core.

@dagstuan @clbond if you're cool with this idea, I'll make some PRs for ng2-redux-router, ng2-reux-form, and also work with you to get them published on npm under the new scope.

  • get router up and running with latest deps (start work for @angular-redux/router package rename router#1)
  • get form up and running with latest deps
  • extract store, form, router examples into an example repo (see angular-redux/example-app)
  • harmonize ngModule naming across form/store/router
  • harmonize package versions
  • simplify existing in-repo examples to be simple test benches on local code
  • make sure the docs are up to date
  • make sure the code examples are up to date
  • rename GH repos
  • deprecate old npm packages
  • update gitter room

Copy link

@dagstuan dagstuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, what do I need to do on my end to move ng2-redux-router?

@SethDavenport
Copy link
Member Author

Thanks @dagstuan - I already copied the router code over to angular-redux/router and made you admin.

You shouldn't need to do anything yet - I'm working to get router, core, and form all playing together nicely under the new scope and then I'll publicize the change over. At that point I'll give you publish rights to the new package too.

@e-schultz
Copy link
Member

@wbuchwalter any input on this?

Copy link
Member

@e-schultz e-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it'd make more sense to be @angular-redux/store ? I could see having a 'core' repo that is more utility functions/etc - that get bundled up into store - sort of the things that are under '/util' could eventually be moved there.

50/50 on this - could be easily swayed either way

@SethDavenport
Copy link
Member Author

store also works

@SethDavenport
Copy link
Member Author

Put together an example app that combines router, store, and eventually form with the Angular CLI.

@wbuchwalter
Copy link
Member

Sorry for the delay, I was somewhere remote with no internet for a while.
That makes total sense 👍

@SethDavenport
Copy link
Member Author

Awesome @wbuchwalter, thanks.

@SethDavenport
Copy link
Member Author

@e-schultz should we harmonize versions across packages? e.g. /store is at 5.1.0, should be bump up form and router to 5.1.0 as well?

@e-schultz
Copy link
Member

@SethDavenport might as well for this push.

SethDavenport pushed a commit to SethDavenport/form that referenced this pull request Jan 29, 2017
SethDavenport added a commit to angular-redux/form that referenced this pull request Jan 29, 2017
@SethDavenport SethDavenport force-pushed the chore/update-package-naming branch from 3b14f0e to c43bf95 Compare February 4, 2017 17:20
@SethDavenport
Copy link
Member Author

Merging what we have now. Checklist moved to #288

@SethDavenport SethDavenport merged commit af4023f into angular-redux:master Feb 4, 2017
@SethDavenport SethDavenport deleted the chore/update-package-naming branch February 4, 2017 17:27
smithad15 pushed a commit to angular-redux/platform that referenced this pull request Jul 9, 2018
Bytava added a commit to Bytava/angular_redux_platform that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants