-
Notifications
You must be signed in to change notification settings - Fork 200
Update package naming #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package naming #304
Conversation
dagstuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, what do I need to do on my end to move ng2-redux-router?
|
Thanks @dagstuan - I already copied the router code over to angular-redux/router and made you admin. You shouldn't need to do anything yet - I'm working to get router, core, and form all playing together nicely under the new scope and then I'll publicize the change over. At that point I'll give you publish rights to the new package too. |
|
@wbuchwalter any input on this? |
e-schultz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if it'd make more sense to be @angular-redux/store ? I could see having a 'core' repo that is more utility functions/etc - that get bundled up into store - sort of the things that are under '/util' could eventually be moved there.
50/50 on this - could be easily swayed either way
|
store also works |
|
Put together an example app that combines router, store, and eventually form with the Angular CLI. |
|
Sorry for the delay, I was somewhere remote with no internet for a while. |
|
Awesome @wbuchwalter, thanks. |
|
@e-schultz should we harmonize versions across packages? e.g. /store is at 5.1.0, should be bump up form and router to 5.1.0 as well? |
|
@SethDavenport might as well for this push. |
Adapt to org rename. See angular-redux/store#304
3b14f0e to
c43bf95
Compare
|
Merging what we have now. Checklist moved to #288 |
Adapt to org rename. See angular-redux/store#304
Adapt to org rename. See angular-redux/store#304
Now that Angular 4 is in beta, we need to update our package's naming since ng2-redux doesn't make a lot of sense any more.
After conferring with my colleagues we're thinking of also taking the opportunity to move to scoped pages under our github org (
@angular-redux).The current idea is as follows:
@angular-redux/store[UPDATED, wascorebefore]@angular-redux/router@angular-redux/form... with potentially others down the line.
This PR starts the process of updating ng2-redux to
@angular-redux/core.@dagstuan @clbond if you're cool with this idea, I'll make some PRs for ng2-redux-router, ng2-reux-form, and also work with you to get them published on npm under the new scope.