Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Datepicker issue3879 - #4473

Closed
thalen wants to merge 14 commits into
angular-ui:masterfrom
thalen:datepicker-issue3879
Closed

Datepicker issue3879#4473
thalen wants to merge 14 commits into
angular-ui:masterfrom
thalen:datepicker-issue3879

Conversation

@thalen

@thalen thalen commented Sep 25, 2015

Copy link
Copy Markdown

This solves issue #3879, a problem regarding the datepicker.
I've added a method for date calculation. If a date is selected and the user moves to next or previous month, the date selection is kept if the date is visible in the new view. Otherwise no date is selected.
This also works when navigating via year or month mode.
I've added some tests for this new functionality, I've done some manually testing in Chrome, Firefox and IE9.

Regards,
Olle Thalén

Comment thread Gruntfile.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change

@wesleycho

Copy link
Copy Markdown
Contributor

I'm not sure this solves the problem in an ideal way - this behavior should likely not be hidden behind a config flag for example. What are your thoughts on how it should be solved @Foxandxss ?

@wesleycho

Copy link
Copy Markdown
Contributor

Going to close this due to the age - the datepicker has changed quite a lot in the past couple of months, and I'm unsure this particular attempt is the right approach.

Feel free to open a new PR based on current master.

@wesleycho wesleycho closed this Jan 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants