fix(@schematics/angular): remove extra comma in component schematic#13740
Merged
mgechev merged 2 commits intoangular:masterfrom Feb 22, 2019
Merged
fix(@schematics/angular): remove extra comma in component schematic#13740mgechev merged 2 commits intoangular:masterfrom
mgechev merged 2 commits intoangular:masterfrom
Conversation
This was introduced by angular#13690
alan-agius4
approved these changes
Feb 22, 2019
alan-agius4
added
the
target: patch
Collaborator
|
Thinking about this, we should probably remove ViewEncapsulation from this file. Inc the import. Since now we set the defaultViewEncapsulation in main.ts |
Member
Author
|
@alan-agius4 Sure. I updated the PR |
cexbrayat
force-pushed
the
fix/trailing-comma
branch
from
e11c84d to
6ddfb2e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced by #13690
Previously to this commit, a trailing comma was always added after styles/styleUrls
The
viewEncapsulationalso adds one, so there is an extra one.Fixes: #13742