Skip to content

fix(@angular-devkit/build-angular): parse web-workers in tests when webWorkerTsConfig is defined#21160

Merged
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:web-worker-syntax
Jun 22, 2021
Merged

fix(@angular-devkit/build-angular): parse web-workers in tests when webWorkerTsConfig is defined#21160
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:web-worker-syntax

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

The logic was inverted which caused workers not to be parsed when webWorkerTsConfig is defined.

…ebWorkerTsConfig is defined

The logic was inverted which caused workers not to be parsed when `webWorkerTsConfig` is defined.
@alan-agius4 alan-agius4 reopened this Jun 18, 2021
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 18, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 21, 2021
@filipesilva filipesilva merged commit 06181c2 into angular:master Jun 22, 2021
@alan-agius4 alan-agius4 deleted the web-worker-syntax branch June 22, 2021 17:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants