build: update build-tooling package and enable Node.js 18 tests#25390
Merged
clydin merged 1 commit intoangular:mainfrom Jun 16, 2023
Merged
build: update build-tooling package and enable Node.js 18 tests#25390clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
the
target: patch
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
node-18-tests
branch
3 times, most recently
from
33ede46 to
7fba713
Compare
alan-agius4
commented
Jun 16, 2023
| expect(output.success).toBe(true); | ||
|
|
||
| const response = await fetch(`http://${output.address}:${output.port}/bundle.js`); | ||
| const response = await fetch(`http://localhost:${output.port}/bundle.js`); |
Collaborator
Author
There was a problem hiding this comment.
This is needed as on Node 18 .address this can be an IP v6 example ::1.
alan-agius4
added
the
action: review
devversion
approved these changes
Jun 16, 2023
alan-agius4
added
action: merge
This commit updates the build-tooling package which contains fixes for RBE on Node.js 18. It also enables the Node.js 18 test suit.
alan-agius4
force-pushed
the
node-18-tests
branch
from
7fba713 to
10b1544
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the build-tooling package which contains fixes for RBE on Node.js 18. It also enables the Node.js 18 test suit.