Skip to content

build: update build-tooling package and enable Node.js 18 tests #25390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Jun 16, 2023
Merged

build: update build-tooling package and enable Node.js 18 tests #25390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .circleci/dynamic_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,10 +390,7 @@ workflows:
name: test-node<< matrix.nodeversion >>
matrix:
parameters:
# Disable running this on Node.js 18 for now. This causes failures when using RBE.
# Example: `GLIBC_2.28' not found.
# Likely this is caused by outdated Ubuntu image https://github.com/angular/dev-infra/blob/main/bazel/remote-execution/BUILD.bazel#L21
nodeversion: ['16']
nodeversion: ['16', '18']
requires:
- build

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"devDependencies": {
"@ampproject/remapping": "2.2.1",
"@angular/animations": "16.1.0-rc.0",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#27aea082d8662d61c5a087b320c23e38f9268bfa",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#69da084401b5724a236d7a6fe8be402ff2ea79b3",
"@angular/cdk": "16.0.4",
"@angular/common": "16.1.0-rc.0",
"@angular/compiler": "16.1.0-rc.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_webpack/src/webpack-dev-server/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Dev Server Builder', () => {
const output = (await run.result) as DevServerBuildOutput;
expect(output.success).toBe(true);

const response = await fetch(`http://${output.address}:${output.port}/bundle.js`);
const response = await fetch(`http://localhost:${output.port}/bundle.js`);
Copy link
Copy Markdown
Collaborator Author

@alan-agius4 alan-agius4 Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed as on Node 18 .address this can be an IP v6 example ::1.

expect(await response.text()).toContain(`console.log('hello world')`);

await run.stop();
Expand All @@ -67,7 +67,7 @@ describe('Dev Server Builder', () => {
const output = (await run.result) as DevServerBuildOutput;
expect(output.success).toBe(true);

const response = await fetch(`http://${output.address}:${output.port}/bundle.js`);
const response = await fetch(`http://localhost:${output.port}/bundle.js`);
expect(await response.text()).toContain(`console.log('hello world')`);

await run.stop();
Expand Down
Loading