Skip to content

Conversation

@9kubczas4
Copy link
Contributor

@9kubczas4 9kubczas4 commented Mar 21, 2024

Rename SSR port env variable to SSR_PORT.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Rename the SSR port env variable to SSR_PORT.
It could help to resolve this firebase issue: firebase/firebase-tools#6651 (comment), cause PORT is reserved environment variable: https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add more context in the commit body? Example:
Linking to firebase/firebase-tools#6651 (comment) and explaining that PORT is reserved variable as per https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names?

Additionally the scope should be @schematics/angular, the type can also be a fix.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 22, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review March 22, 2024 08:05
@9kubczas4 9kubczas4 marked this pull request as draft March 22, 2024 14:54
@9kubczas4 9kubczas4 force-pushed the fix/adjust-ssr-port-env-variable branch from c8a9af4 to 7c195cd Compare March 22, 2024 16:20
Rename the SSR port env variable to SSR_PORT.
It could help to resolve this firebase issue: firebase/firebase-tools#6651 (comment), cause PORT is reserved environment variable: https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names.
@9kubczas4 9kubczas4 force-pushed the fix/adjust-ssr-port-env-variable branch from 7c195cd to e1ddc1a Compare March 22, 2024 16:42
@9kubczas4 9kubczas4 requested a review from alan-agius4 March 22, 2024 16:43
@9kubczas4 9kubczas4 marked this pull request as ready for review March 22, 2024 16:43
@9kubczas4 9kubczas4 changed the title refactor(@angular/ssr): rename SSR port env variable fix(@schematics/angular): rename SSR port env variable Mar 22, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 22, 2024
@clydin clydin merged commit 950a445 into angular:main Mar 22, 2024
@inlined
Copy link

inlined commented Apr 2, 2024

This actually breaks Firebase on deploy. PORT is a reserved variable because it's what Functions and Run uses to set the port to listen to. Let's collaborate on a working solution.

@alan-agius4
Copy link
Collaborator

@inlined, should we revert this?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants