`ng build` chokes on processing Angular source maps

[IgorMinar]

Bug Report or Feature Request (mark with an x)

• bug report -> please search issues before submitting

Versions.

@angular/cli: 1.0.0-rc.2
node: 6.9.5
os: darwin x64
@angular/animations: 4.0.0-rc.4
@angular/common: 4.0.0-rc.4
@angular/compiler: 4.0.0-rc.4
@angular/core: 4.0.0-rc.4
@angular/forms: 4.0.0-rc.4
@angular/http: 4.0.0-rc.4
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 4.0.0-rc.4
@angular/platform-browser-dynamic: 4.0.0-rc.4
@angular/platform-server: 4.0.0-rc.4
@angular/router: 4.0.0-rc.4
@angular/service-worker: 1.0.0-beta.7
@angular/cli: 1.0.0-rc.2
@angular/compiler-cli: 4.0.0-rc.2

Repro steps.

1. upgrade a project to angular 4.0.0-rc.4
2. modify node_modules/@angular/cli//models/webpack-configs/common.js to no exclude node_modules from the source-map-loader
3. build the project with ng build or ng build --prod --sm

The log given by the failure.

$ ng build --prod --sm
 92% chunk asset optimization/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-node.js:95
          var code = nextLine.substr(0, mapping.generatedColumn -
                             ^

TypeError: Cannot read property 'substr' of undefined
    at Function.<anonymous> (/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-node.js:95:30)
    at Array.forEach (native)
    at SourceMapConsumer_eachMapping [as eachMapping] (/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-map-consumer.js:155:14)
    at Function.SourceNode_fromStringWithSourceMap [as fromStringWithSourceMap] (/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-node.js:80:24)
    at SourceMapSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/SourceMapSource.js:42:20)
    at ReplaceSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ReplaceSource.js:69:29)
    at CachedSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/CachedSource.js:12:23)
    at /Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:40:49
    at Array.map (native)
    at ConcatSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:39:60)
    at /Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:40:49
    at Array.map (native)
    at ConcatSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:39:60)
    at /Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:40:49
    at Array.map (native)
    at ConcatSource.node (/Users/iminar/Dev/angular/aio/node_modules/webpack-sources/lib/ConcatSource.js:39:60)

Desired functionality.

should build 😄

Mention any other details that might be useful.

[Brocco]

This was related to an issue in the angular repo angular/angular/pull/15226 and is resolved with the newly released rc5. It will work with the CLI once #5480 is resolved.

[IgorMinar]

Unfortunately, I can still reproduce the issue with @angular/core@4.0.0-rc.5 and zone.js@0.8.4.

$ ng build
 92% chunk asset optimization/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-node.js:95
          var code = nextLine.substr(0, mapping.generatedColumn -
                             ^

TypeError: Cannot read property 'substr' of undefined
    at Function.<anonymous> (/Users/iminar/Dev/angular/aio/node_modules/source-map/lib/source-node.js:95:30)

[hansl]

I can't repro locally with just enabling the node modules source maps. It builds (but takes twice the amount of time):

$ npm ls @angular/core
test-decorators@0.0.0 /Users/hansl/Sources/_Temp/test-decorators
├─┬ @angular/cli@1.0.0-rc.2 -> /Users/hansl/Sources/angular-cli
│ ├── @angular/core@4.0.0-rc.5  extraneous
│ └── UNMET PEER DEPENDENCY zone.js@0.7.8

[IgorMinar]

@hansl looked into it more and said that it's due to incorrect source maps coming from @angular/material@2.0.0-beta.2

If I remove all material source maps using:

for i in `find node_modules/\@angular/material/ -name "*.js.map"`; do echo $i; rm $i; done

the error goes away.

[hansl]

Apparently it's a known error in source-map: mozilla/source-map#247 and related in ionic: ionic-team/ionic-app-scripts#796

As long as that issue is not fixed, we cannot really enable source maps in node_modules. Let's chat tomorrow @IgorMinar

[IgorMinar]

@hansl we could fork the project with this patch: mozilla/source-map#257 (comment). I verified that it works.

[hansl]

That would work (but the mapping might be invalid), I'm not sure if that's what we want. Let's talk during the weekly.

[hansl]

Removing this from 1.0 BLOCKING. The plan is to get Mozilla to fix their source-map library (see issues pointed above). If that cannot be done in a timely fashion we will fork it locally in the CLI and use it for a custom loader instead.