Skip to content

Fix 10182 #10184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansl merged 2 commits into from
Apr 5, 2018
Merged

Fix 10182 #10184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0792965
fix(@angular/cli): allow some schematic commands to allow private
hansl Apr 5, 2018
a2a7ed9
test: use latest snapshots of master for e2e
hansl Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@
},
"homepage": "https://github.com/angular/angular-cli",
"dependencies": {
"@angular-devkit/architect": "0.5.0",
"@angular-devkit/core": "0.5.0",
"@angular-devkit/schematics": "0.5.0",
"@schematics/angular": "0.5.0",
"@schematics/update": "0.5.0",
"@angular-devkit/architect": "angular/angular-devkit-architect-builds",
"@angular-devkit/core": "angular/angular-devkit-core-builds",
"@angular-devkit/schematics": "angular/angular-devkit-schematics-builds",
"@schematics/angular": "angular/schematics-angular-builds",
"@schematics/update": "angular/schematics-update-builds",
"chalk": "~2.2.0",
"ember-cli-string-utils": "^1.0.0",
"fs-extra": "^4.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/@angular/cli/commands/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const SilentError = require('silent-error');
export default class AddCommand extends SchematicCommand {
readonly name = 'add';
readonly description = 'Add support for a library to your project.';
readonly allowPrivateSchematics = true;
scope = CommandScope.inProject;
arguments = ['collection'];
options: Option[] = [];
Expand Down
2 changes: 2 additions & 0 deletions packages/@angular/cli/models/schematic-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export interface GetOptionsResult {

export abstract class SchematicCommand extends Command {
readonly options: Option[] = [];
readonly allowPrivateSchematics: boolean = false;
private _host = new NodeJsSyncHost();
private _workspace: experimental.workspace.Workspace;
private _deAliasedName: string;
Expand Down Expand Up @@ -140,6 +141,7 @@ export abstract class SchematicCommand extends Command {
options: schematicOptions,
debug: debug,
logger: this.logger,
allowPrivate: this.allowPrivateSchematics,
})
.subscribe({
error: (err: Error) => {
Expand Down