New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): Add progress reporters for webpack builds #13405

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@GingerGeek
Copy link

GingerGeek commented Jan 10, 2019

  • Add progress reporters for webpack builds. Previously only the default webpack progress handler was used. The default handler did not display well in all CI environments as it attempted to use the same console line for all progress updates.
  • Add simple progress report, logging on new lines each time the build stage or build % changes.
  • Add verbose progress report, logging on new lines on every progress update with additional data provided by webpack.
  • Change default behaviour on non TTY consoles to use the simple progress report over the current behaviour of no progress reporting, this gives visibility over the status of build.

Previews

default-webpack

Delegate to default handler within ProgressPlugin in webpack (existing behaviour)
default-webpack

simple-color

Logging on new lines each time the build stage or build percentage changes (w/ colour)
simple-color

verbose-color

Logging on new lines on every progress update with additional data provided by webpack (w colour)
verbose-color

simple-plain

Logging on new lines each time the build stage or build percentage changes (w/o colour)
simple-plain

verbose-plain

Logging on new lines on every progress update with additional data provided by webpack (w/o colour)
verbose-plain

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 10, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Jan 10, 2019

@GingerGeek GingerGeek force-pushed the GingerGeek:build-progress-reporters branch 2 times, most recently from bca7998 to 8341a89 Jan 10, 2019

feat(@angular-devkit/build-angular): Add progress reporters for webpa…
…ck builds

Add progress reporters for webpack builds. Previously only the default webpack
progress handler was used. The default handler did not display well in all CI
environments as it attempted to use the same console line for all progress updates.
Add simple progress report, logging on new lines each time the build stage or build
percentage changes.
Add verbose progress report, logging on new lines on every progress update with
additional data provided by webpack.
Change default behaviour on non TTY consoles to use the simple progress report over
the current behaviour of no progress reporting, this gives visibility over the status
of build.

@GingerGeek GingerGeek force-pushed the GingerGeek:build-progress-reporters branch from 8341a89 to 6294fb9 Jan 10, 2019

@GingerGeek

This comment has been minimized.

Copy link

GingerGeek commented Jan 11, 2019

@googlebot CLA should be sorted!

@mgechev

This comment has been minimized.

Copy link
Member

mgechev commented Jan 11, 2019

@GingerGeek this is a large change and we should discuss further if we can merge it.

For such big changes, I'd recommend you to first open an issue so we can discuss if this is in the scope of the project.

@GingerGeek

This comment has been minimized.

Copy link

GingerGeek commented Jan 12, 2019

@mgechev Apologies, I've created an issue to discuss this further: #13426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment