Skip to content

fix(@angular/cli): change strategy for opening the browser when we ca…#13615

Merged
alexeagle merged 1 commit intoangular:masterfrom
wKoza:gh-13575
Feb 9, 2019
Merged

fix(@angular/cli): change strategy for opening the browser when we ca…#13615
alexeagle merged 1 commit intoangular:masterfrom
wKoza:gh-13575

Conversation

@wKoza
Copy link
Contributor

@wKoza wKoza commented Feb 7, 2019

…ll ng doc with Windows.

Closes #13575

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Feb 8, 2019

@wKoza, just a side note, we should not add an addition open for the browser to open. We should always rely on the default browser.

As we'd like to limit the options, and avoid adding unnecessary once.

@wKoza
Copy link
Contributor Author

wKoza commented Feb 8, 2019

@alan-agius4 , I understand concerning the option property. I hadn't default browser (It's not my PC ...); But now It's ok; I no longer need of the app property

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@alan-agius4
Copy link
Collaborator

@wKoza small nit, would you mind fixing the commit msg? As the description is not correct.

Thanks

Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alexeagle alexeagle merged commit ec94f42 into angular:master Feb 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng doc does not open the documentation in the browser.

5 participants