Skip to content

fix(@angular-devkit/build-angular): always use ECMA 5 optimizations with terser#15602

Merged
vikerman merged 1 commit intoangular:masterfrom
clydin:terser-ecma-6
Sep 19, 2019
Merged

fix(@angular-devkit/build-angular): always use ECMA 5 optimizations with terser#15602
vikerman merged 1 commit intoangular:masterfrom
clydin:terser-ecma-6

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Sep 15, 2019

There appears to be defects related to terser's ECMA 6 options. The optimizations present a minimal size improvement in general and was the default for differential loading prior to #15566. Further investigation is required to determine the underlying cause within terser.

Fixes #15580

…ith terser

There appears to be defects related to terser's ECMA 6 options.  The optimizations present a minima size improvement in general.  Further investigation is required to determine the underlying cause within terser.

Fixes angular#15580
@clydin clydin added the target: patch This PR is targeted for the next patch release label Sep 15, 2019
@clydin clydin requested a review from alan-agius4 September 15, 2019 13:59
@filipesilva
Copy link
Copy Markdown
Contributor

Is there a repro we can provide to the Terser team so they can address this?

@vikerman vikerman merged commit e444412 into angular:master Sep 19, 2019
@clydin clydin deleted the terser-ecma-6 branch September 19, 2019 22:21
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@angular-devkit/build-angular:v0.803.4 build fails for differential loading with optimization=true

5 participants