Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): augment base HREF when localizing #16332

Merged
merged 3 commits into from Dec 4, 2019

Conversation

@clydin
Copy link
Member

clydin commented Dec 2, 2019

All locale i18n options now support an object form which allows a base HREF to be defined for the locale. This allows each locale to optionally define a custom base HREF that will be combined with the base HREF defined for the build configuration.

By default if the shorthand form for the locale is used or the field is not present in the longhand form, the locale code will be used as the base HREF. To disable automatic augmentation, a base HREF value of an empty string ("") can be used. This will prevent anything from being added to the existing base HREF.

For common scenarios, the shorthand form will result in the preferred and recommended outcome of each built locale variant of the application having a defined base HREF containing the locale code.

Closes #16301

@googlebot googlebot added the cla: yes label Dec 2, 2019
@clydin clydin force-pushed the clydin:i18n-basehref-2 branch from c9ef2be to 78217d9 Dec 2, 2019
@clydin clydin removed the blocked label Dec 2, 2019
All locale i18n options now support an object form which allows a base HREF to be defined for the locale.  Each locale can now optionally define a custom base HREF that will be combined with the base HREF defined for the build configuration.  By default if the shorthand form for the locale is used or the field is not present in the longhand form, the locale code will be used as the base HREF.  To disable automatic augmentation a base HREF value of an empty string (`""`) can be used.  This will prevent anything from being added to the existing base HREF.

For common scenarios, the shorthand form will result in the preferred and recommended outcome of each built locale variant of the application containing a defined base HREF  containing the locale code.
@clydin clydin force-pushed the clydin:i18n-basehref-2 branch from a3a1023 to f71d2ab Dec 2, 2019
@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Dec 2, 2019

I wonder if the default base HREF could be in some way computed from the outputPath?

@clydin clydin requested a review from alan-agius4 Dec 2, 2019
@clydin clydin force-pushed the clydin:i18n-basehref-2 branch from f71d2ab to 8b4aa9a Dec 4, 2019
… direct localize usage
Copy link
Collaborator

alan-agius4 left a comment

LGTM

@dgp1130 dgp1130 merged commit 97c0d57 into angular:master Dec 4, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@dgp1130

This comment has been minimized.

Copy link
Collaborator

dgp1130 commented Dec 4, 2019

Merged all 3 commits to v9.0.x patch branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.