Skip to content

fix(@angular-devkit/build-angular): resolve webdriver-manager from protractor location #16852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgp1130 merged 1 commit into from
Feb 6, 2020
Merged

fix(@angular-devkit/build-angular): resolve webdriver-manager from protractor location #16852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions packages/angular_devkit/build_angular/src/protractor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,15 @@ function runProtractor(root: string, options: ProtractorBuilderOptions): Promise
async function updateWebdriver() {
// The webdriver-manager update command can only be accessed via a deep import.
const webdriverDeepImport = 'webdriver-manager/built/lib/cmds/update';
const importOptions = [
// When using npm, webdriver is within protractor/node_modules.
`protractor/node_modules/${webdriverDeepImport}`,
// When using yarn, webdriver is found as a root module.
webdriverDeepImport,
];

let path;
for (const importOption of importOptions) {
try {
path = require.resolve(importOption);
} catch (error) {
if (error.code !== 'MODULE_NOT_FOUND') {
throw error;
}
try {
const protractorPath = require.resolve('protractor');

path = require.resolve(webdriverDeepImport, { paths: [protractorPath] });
} catch (error) {
if (error.code !== 'MODULE_NOT_FOUND') {
throw error;
}
}

Expand Down