fix(@ngtools/webpack): always use VE for deprecated string route discovery#17086
Merged
dgp1130 merged 1 commit intoangular:masterfrom Feb 26, 2020
Merged
fix(@ngtools/webpack): always use VE for deprecated string route discovery#17086dgp1130 merged 1 commit intoangular:masterfrom
dgp1130 merged 1 commit intoangular:masterfrom
Conversation
…overy When in JIT mode during lazy route discovery, the Ivy compiler willl attempt to parse templates which may fail when this plugin is used with webpack loaders that support custom template formats. The string lazy routes must be discovered before the webpack build starts but the template loading/processing does not occur until the webpack build commences. Fixes: angular#17002
clydin
added
target: major
alan-agius4
approved these changes
Feb 25, 2020
Collaborator
|
Also merged to 9.0.x patch branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in JIT mode during lazy route discovery, the Ivy compiler willl attempt to parse templates which may fail when this plugin is used with webpack loaders that support custom template formats. The string lazy routes must be discovered before the webpack build starts but the template loading/processing does not occur until the webpack build commences.
Fixes: #17002