Revert change where sourcemaps were not ignored in dev. #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheLarkInn
commented
Aug 17, 2016
TheLarkInn
commented
- Ignore all inlined sourcemaps from node_modules.
- Do not surpress warnings.
…ring them across the board
…ring them across the board
…ring them across the board
addon/ng2/tasks/serve-webpack.ts
Outdated
|
|
||
| return new Promise((resolve, reject) => { | ||
| server.listen(commandOptions.port, `${commandOptions.host}`, function(err, stats) { | ||
|
|
Contributor
|
One nit then LGTM. |
…github.com/thelarkinn/angular-cli into feature/ignore_all_node_module_source_maps
Member
Author
|
@hansl got back around to fixing nit, I'll merge when tests pass. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.