upgrade(): angular2 beta.6 #186
Conversation
|
ok, it turns out that beta.5 is broken and that's why this PR makes the CLI to generate a project that is broken at runtime. There is a fix on the way: angular/angular#7002 I think we might need to wait for that to land and delay the release further. :-( I hope that we can cut beta.6 tomorrow. |
|
Upgraded to beta.6. Tested locally. This will fail because beta.6 doesn't exist, but I'll rerun travis when it does. |
hansl
force-pushed
the
typings
branch
2 times, most recently
from
4723923 to
a43609d
Compare
|
@IgorMinar PTAL |
| "jasmine": "github:DefinitelyTyped/DefinitelyTyped/jasmine/jasmine.d.ts#26c98c8a9530c44f8c801ccc3b2057e2101187ee" | ||
| }, | ||
| "ambientDependencies": { | ||
| "es6-shim": "github:DefinitelyTyped/DefinitelyTyped/es6-shim/es6-shim.d.ts#6697d6f7dadbf5773cb40ecda35a76027e0783b2" |
There was a problem hiding this comment.
Since angular needs only es6 collections and es6 promises, do we want pull in the whole es6-shim typings? While convenient, this is more than what is necessary.
This is all that angular's public api surface requires: https://github.com/angular/angular/tree/builds-js/typings
|
lgtm, go ahead and merge |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
No description provided.