Skip to content

Conversation

@drumonii
Copy link
Contributor

@drumonii drumonii commented Oct 4, 2020

When using the -C option of update, the commit message of the migration is missing a blank line between the subject and body.

For example,

Previously was missing blank line after the commit subject:

@angular/cli migration - rename-browserslist-config
Update Browserslist configuration file name to '.browserslistrc' from deprecated 'browserslist'.

Now fixed:

@angular/cli migration - rename-browserslist-config

Update Browserslist configuration file name to '.browserslistrc' from deprecated 'browserslist'.

Adds a blank line in the commit message between the subject and body in order to properly separate the two.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 4, 2020
@clydin clydin merged commit 7254d18 into angular:master Oct 4, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants