Skip to content

Deprecate several dev-server builder options #18988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 2 commits into from
Oct 7, 2020
Merged

Deprecate several dev-server builder options #18988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71ba308
refactor(@angular-devkit/build-angular): deprecate a number of dev-se…
alan-agius4 Oct 7, 2020
a762a42
refactor(@angular-devkit/build-angular): deprecate hmrWarning and ser…
alan-agius4 Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/angular_devkit/build_angular/src/dev-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,7 @@ export function buildServePath(
let servePath = serverOptions.servePath;
if (!servePath && servePath !== '') {
const defaultPath = _findDefaultServePath(browserOptions.baseHref, browserOptions.deployUrl);
const showWarning = serverOptions.servePathDefaultWarning;
if (defaultPath == null && showWarning) {
if (defaultPath == null) {
logger.warn(tags.oneLine`
Warning: --deploy-url and/or --base-href contain unsupported values for ng serve. Default
serve path of '/' used. Use --serve-path to override.
Expand Down
30 changes: 20 additions & 10 deletions packages/angular_devkit/build_angular/src/dev-server/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,14 @@
"hmrWarning": {
"type": "boolean",
"description": "Show a warning when the --hmr option is enabled.",
"default": true
"default": true,
"x-deprecated": "No longer has an effect."
},
"servePathDefaultWarning": {
"type": "boolean",
"description": "Show a warning when deploy-url/base-href use unsupported serve path values.",
"default": true
"default": true,
"x-deprecated": "No longer has an effect."
},
"optimization": {
"description": "Enables optimization of the build output.",
Expand All @@ -115,12 +117,14 @@
{
"type": "boolean"
}
]
],
"x-deprecated": "Use the \"optimization\" option in the browser builder instead."
},
"aot": {
"type": "boolean",
"description": "Build using Ahead of Time compilation.",
"x-user-analytics": 13
"x-user-analytics": 13,
"x-deprecated": "Use the \"aot\" option in the browser builder instead."
},
"sourceMap": {
"description": "Output sourcemaps.",
Expand Down Expand Up @@ -154,27 +158,33 @@
{
"type": "boolean"
}
]
],
"x-deprecated": "Use the \"sourceMap\" option in the browser builder instead."
},
"vendorChunk": {
"type": "boolean",
"description": "Use a separate bundle containing only vendor libraries."
"description": "Use a separate bundle containing only vendor libraries.",
"x-deprecated": "Use the \"vendorChunk\" option in the browser builder instead."
},
"commonChunk": {
"type": "boolean",
"description": "Use a separate bundle containing code used across multiple bundles."
"description": "Use a separate bundle containing code used across multiple bundles.",
"x-deprecated": "Use the \"commonChunk\" option in the browser builder instead."
},
"baseHref": {
"type": "string",
"description": "Base url for the application being built."
"description": "Base url for the application being built.",
"x-deprecated": "Use the \"baseHref\" option in the browser builder instead."
},
"deployUrl": {
"type": "string",
"description": "URL where files will be deployed."
"description": "URL where files will be deployed.",
"x-deprecated": "Use the \"deployUrl\" option in the browser builder instead."
},
"progress": {
"type": "boolean",
"description": "Log progress to the console while building."
"description": "Log progress to the console while building.",
"x-deprecated": "Use the \"progress\" option in the browser builder instead."
},
"poll": {
"type": "number",
Expand Down