Skip to content

build: use @angular/dev-infra-private for bazel stamping #18993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clydin merged 1 commit into from
Oct 7, 2020
Merged

build: use @angular/dev-infra-private for bazel stamping #18993

clydin merged 1 commit into from
Oct 7, 2020

Conversation

@clydin
Copy link
Member

@clydin clydin commented Oct 7, 2020 •
edited
Loading

Some initial preparation for building the packages with bazel. Currently unused.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 7, 2020
@google-cla google-cla bot added the cla: yes label Oct 7, 2020
@clydin clydin requested a review from josephperrott October 7, 2020 16:32
josephperrott
josephperrott approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2020
@clydin clydin merged commit f9d5960 into angular:master Oct 7, 2020
@clydin clydin deleted the bazel-stamping branch October 7, 2020 16:36
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 7, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clydin @josephperrott