Skip to content

refactor(@angular-devkit/build-angular): additional webpack 5 type improvements #18994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Oct 7, 2020
Merged

refactor(@angular-devkit/build-angular): additional webpack 5 type improvements #18994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular_devkit/build_angular/src/webpack/plugins/common-js-usage-warn-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import { isWebpackFiveOrHigher } from '../../utils/webpack-version';
const CommonJsRequireDependency = require('webpack/lib/dependencies/CommonJsRequireDependency');
const AMDDefineDependency = require('webpack/lib/dependencies/AMDDefineDependency');

// The below is extended because there are not in the typings
interface WebpackModule extends compilation.Module {
// The below is used to remain compatible with both Webpack 4 and 5
interface WebpackModule {
name?: string;
rawRequest?: string;
dependencies: WebpackModule[];
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/webpack/plugins/optimize-css-webpack-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function hook(
});
} else {
compilation.hooks.optimizeChunkAssets
.tapPromise(PLUGIN_NAME, (chunks: compilation.Chunk[]) => {
.tapPromise(PLUGIN_NAME, (chunks: Iterable<compilation.Chunk>) => {
const files: string[] = [];
for (const chunk of chunks) {
if (!chunk.files) {
Expand Down