-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@angular-devkit/build-angular): integrate Angular compiler linker #19641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3aae85 to
691bf5b
Compare
packages/angular_devkit/build_angular/src/babel/webpack-loader.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/babel/presets/application.ts
Outdated
Show resolved
Hide resolved
359e075 to
4cb37ee
Compare
4cb37ee to
fc0b6fe
Compare
908bf94 to
34f27cf
Compare
34f27cf to
4990f30
Compare
alan-agius4
requested changes
Jan 7, 2021
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small NIT.
tests/legacy-cli/e2e/tests/generate/library/library-consumption-linker.ts
Show resolved
Hide resolved
tests/legacy-cli/e2e/tests/generate/library/library-consumption-linker.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/babel/webpack-loader.ts
Outdated
Show resolved
Hide resolved
ab756e9 to
f55ec21
Compare
The newly introduced library linker mode that removes the need for ngcc is integrated into the Angular CLI's build system. This allows libraries that are built in linker mode to be used when building an application.
…test This adds a new E2E test that creates a library, converts it to use partial AOT compilation (linker mode), and integrates the library into an application. This provides a full workflow test of the new method to produce a publishable Angular library.
f55ec21 to
778f95e
Compare
alan-agius4
approved these changes
Jan 8, 2021
alan-agius4
reviewed
Jan 8, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly introduced library linker mode that removes the need for ngcc is now integrated into the Angular CLI's build system. This allows libraries that are built in linker mode to be used when building an application. Linker processing is only performed on files that contain partial compiled AOT code.
NOTE: Support for the linker is currently experimental.